Messages in this thread | | | Date | Sun, 20 Jun 2010 09:30:28 +0800 | From | Wan ZongShun <> | Subject | Re: [rtc-linux] [PATCH v3] RTC: Add JZ4740 RTC driver |
| |
Lars-Peter Clausen : > Wan ZongShun wrote: >>> This patch adds support for the RTC unit on JZ4740 SoCs. >>> >>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> >>> Cc: Alessandro Zummo <a.zummo@towertech.it> >>> Cc: Paul Gortmaker <p_gortmaker@yahoo.com> >>> Cc: rtc-linux@googlegroups.com >>> >>> -- >>> Changes since v1 >>> - Use dev_get_drvdata directly instead of wrapping it in dev_to_rtc >>> - Add common implementation for jz4740_rtc_{alarm,update}_irq_enable >>> - Check whether rtc structure could be allocated >>> - Remove deadlocks which could occur if the HW was broken >>> >>> Changes since v2 >>> - Use kzalloc instead of kmalloc >>> - Propagate errors in jz4740_rtc_reg_write up to its callers >> Acked-by: Wan ZongShun <mcuos.com@gmail.com> >> >> Andrew, the v3 patch has fixed some above issues, it looks good to me >> now. >> Could you please consider merging it to your git tree? >> > Hi > > As written in the introduction mail to this thread it would be good if > the majority of the patches could go through Ralfs tree. > So if the patch is good an "Acked-by:" would be preferable. > Okay, Sound like good to me, please do you want to do. Acked-by: Wan ZongShun <mcuos.com@gmail.com>
> Thanks, > - Lars > > >
| |