lkml.org 
[lkml]   [2010]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH] Topcliff PHUB: Generate PacketHub driver
    > +config PCH_IEEE1588
    > + tristate "PCH IEEE1588"
    > + depends on PCI
    > + help
    > + If you say yes to this option, support will be included for the
    > + PCH IEEE1588 Host controller.
    > +

    Is this really supposed to be part of this patch?

    > +config PCH_PHUB
    > + tristate "PCH PHUB"
    > + depends on PCI
    > + help
    > + If you say yes to this option, support will be included for the
    > + PCH Packet Hub Host controller.
    > + This driver is for PCH Packet hub driver for Topcliff.
    > + This driver is integrated as built-in.
    > + This driver can access GbE MAC address.
    > + This driver can access HW register.
    > + You can also be integrated as module.
    > +
    > +config PCH_CAN_PCLK_50MHZ
    > + bool "CAN PCLK 50MHz"
    > + depends on PCH_PHUB
    > + help
    > + If you say yes to this option, clock is set to 50MHz.(For CAN
    > control)
    > +

    Ohtak-san, I remember you said PCH_CAN_PCLK_50MHZ was in the patch
    because you used to have a hw bug. If that hw bug has been fixed, this config
    option shall also be removed. Otherwise, you have to build multiple kernel
    binaries for different hardware configurations as Alan pointed out.

    > diff --git a/drivers/char/Makefile b/drivers/char/Makefile
    > index f957edf..dc092d0 100644
    > --- a/drivers/char/Makefile
    > +++ b/drivers/char/Makefile
    > @@ -111,6 +111,10 @@ obj-$(CONFIG_PS3_FLASH) += ps3flash.o
    > obj-$(CONFIG_JS_RTC) += js-rtc.o
    > js-rtc-y = rtc.o
    >
    > +obj-$(CONFIG_PCH_IEEE1588) += pch_ieee1588/
    > +

    Ditto



    \
     
     \ /
      Last update: 2010-06-18 10:11    [W:0.040 / U:30.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site