lkml.org 
[lkml]   [2010]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation
Date
On Friday, June 18, 2010, Dave Airlie wrote:
> On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > I have recently noticed a 55 sec. delay during the "device freeze"
> > phase of hibernation on my test-bed HP nx6325. Due to the 100%
> > reproducibility of it I was able to narrow it down to
> > radeon_suspend_kms() and then it turned out that the delay occured
> > somewhere in radeon_bo_evict_vram(). However, it doesn't seem really
> > necessary or even very useful to me to evict VRAM at this particular
> > point, because we're going to create an image and bring the device
> > back to the fully functional state in a little while. Thus, I think
> > the VRAM evicition can be skipped for state.event == PM_EVENT_FREEZE,
> > which makes the delay go away.
>
> I'm not 100% sure of the hibernate sequencing and its early in the
> morning, but we want to evict VRAM before image building so we can have
> the contents of VRAM in the image so we can restore them on resume. Does
> this just avoid evicting them a second time after we created the image?

No, it's the first time, before creating the image, but I didn't seen any
difference on resume with and without the patch, so I thought it was a good
idea. :-)
If you don't like it, though, I guess it will be necessary to find the root
cause of the delay.

Rafael


\
 
 \ /
  Last update: 2010-06-19 01:27    [from the cache]
©2003-2011 Jasper Spaans