lkml.org 
[lkml]   [2010]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 5/6] usb/gadget: Do not take BKL for gadget->ops->ioctl
    Date
    On Friday 18 June 2010, Michał Nazarewicz wrote:
    > On Tue, 01 Jun 2010 23:04:44 +0200, Arnd Bergmann <arnd@arndb.de> wrote:
    > > There is no gadget driver in the tree that
    > > actually implements the ioctl operation, so
    > > obviously it is not necessary to hold the
    > > BKL around the call.
    >
    > Should the callback in ops be renamed to unlocked_ioctl then as to not
    > create confusion? Just a thought.

    No, we decided that the .unlocked_ioctl naming was a bad idea in the other
    places after all and they should eventually get renamed back to .ioctl
    once all the locked versions are gone.

    Arnd
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-18 20:25    [W:0.024 / U:20.904 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site