Messages in this thread | | | Subject | Re: [RFC 1/3] Unified NMI delayed call mechanism | From | Peter Zijlstra <> | Date | Fri, 18 Jun 2010 14:48:24 +0200 |
| |
On Fri, 2010-06-18 at 14:25 +0200, Andi Kleen wrote: > > So aside from the should this be perf or not, the above is utter > > gibberish. Whoever came up with this nonsense? > > This is pretty much how softirqs (and before them bottom halves) work. > I believe Linus invented that scheme originally back in the early > days of Linux.
Doesn't mean its the right abstraction for this.
> It's actually quite simple and works well
And adds more code than it removes whilst providing a very limited service.
You generally want to pass more information along anyway, now your callback function needs to go look for it. Much better to pass a work_struct like thing around that is contained in the state it needs.
| |