Messages in this thread Patch in this message | | | Date | Thu, 17 Jun 2010 10:14:04 +0200 | From | Tejun Heo <> | Subject | Re: [patch] percpu in linux-2.6.35-rc3 |
| |
Andi, thanks for forwarding.
Pavel, I wrote up the patch description, added SOBs and committed it to percpu#for-linus. Will push it to mainline later.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-linus
Thanks.
From a92d3ff9e5dbd958d8008a3e7a573e988e370ca3 Mon Sep 17 00:00:00 2001 From: Pavel V. Panteleev <pp_84@mail.ru> Date: Thu, 17 Jun 2010 10:07:25 +0200 Subject: [PATCH] percpu: fix trivial bugs in pcpu_build_alloc_info()
Fix the following two trivial bugs in pcpu_build_alloc_info()
* we should memset group_cnt to 0 by size of group_cnt, not size of group_map (both are of the same size, so the bug isn't dangerous)
* we can delete useless variable group_cnt_max.
Signed-off-by: Pavel V. Panteleev <pp_84@mail.ru> Signed-off-by: Tejun Heo <tj@kernel.org> --- mm/percpu.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/percpu.c b/mm/percpu.c index 39f7dfd..46485e1 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -1086,7 +1086,7 @@ struct pcpu_alloc_info * __init pcpu_build_alloc_info( static int group_map[NR_CPUS] __initdata; static int group_cnt[NR_CPUS] __initdata; const size_t static_size = __per_cpu_end - __per_cpu_start; - int group_cnt_max = 0, nr_groups = 1, nr_units = 0; + int nr_groups = 1, nr_units = 0; size_t size_sum, min_unit_size, alloc_size; int upa, max_upa, uninitialized_var(best_upa); /* units_per_alloc */ int last_allocs, group, unit; @@ -1096,7 +1096,7 @@ struct pcpu_alloc_info * __init pcpu_build_alloc_info(
/* this function may be called multiple times */ memset(group_map, 0, sizeof(group_map)); - memset(group_cnt, 0, sizeof(group_map)); + memset(group_cnt, 0, sizeof(group_cnt));
/* * Determine min_unit_size, alloc_size and max_upa such that @@ -1130,7 +1130,6 @@ struct pcpu_alloc_info * __init pcpu_build_alloc_info( } group_map[cpu] = group; group_cnt[group]++; - group_cnt_max = max(group_cnt_max, group_cnt[group]); }
/* -- 1.6.4.2
| |