Messages in this thread | | | Date | Thu, 17 Jun 2010 23:36:38 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early |
| |
On 06/17, Eric W. Biederman wrote: > > The task->children isn't changed until __unhash_process() which runs > after flush_proc_task().
Yes. But this is only the current implementation detail. It would be nice to cleanup the code so that EXIT_DEAD tasks are never sit in ->children list.
> So we should be able to come up with > a variant of do_wait() that zap_pid_ns_processes can use that does > what we need.
See above...
Even if we modify do_wait() or add the new variant, how the caller can wait for EXIT_DEAD tasks? I don't think we want to modify release_task() to do __wake_up_parent() or something similar.
Oleg.
| |