lkml.org 
[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/7] perf record: Avoid synthesizing mmap() for all processes in per-thread mode
    Date
    From: Stephane Eranian <eranian@google.com>

    A bug was introduced by commit c45c6ea2e5c57960dc67e00294c2b78e9540c007.

    Perf record was scanning /proc/PID to create synthetic PERF_RECOR_MMAP
    entries even though it was running in per-thread mode. There was a bogus
    check to select what mmaps to synthesize. We only need all processes in
    system-wide mode.

    Cc: David S. Miller <davem@davemloft.net>
    Cc: Frédéric Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    LKML-Reference: <4c192107.4f1ee30a.4316.fffff98e@mx.google.com>
    Signed-off-by: Stephane Eranian <eranian@google.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-record.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index 39c7247..5efc3fc 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -714,7 +714,7 @@ static int __cmd_record(int argc, const char **argv)
    if (perf_guest)
    perf_session__process_machines(session, event__synthesize_guest_os);

    - if (!system_wide && cpu_list)
    + if (!system_wide)
    event__synthesize_thread(target_tid, process_synthesized_event,
    session);
    else
    --
    1.6.2.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-17 22:43    [W:0.020 / U:2.668 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site