lkml.org 
[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Staging: comedi: fix code style errors in s626.c
On Fri, May 28, 2010 at 04:31:28PM +0100, John Sheehan wrote:
> From: John Sheehan <john.d.sheehan@gmail.com>
>
> A patch for s626.c to fix errors reported by
> checkpatch.pl tool, namely,
> code indent should use tabs where possible
> "foo * bar" should be "foo *bar"
> trailing statements should be on next line
>
> Signed-off-by: John Sheehan <john.d.sheehan@gmail.com>
> ---
> drivers/staging/comedi/drivers/s626.c | 67 +++++++++++++++++++--------------
> 1 files changed, 39 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index a3cc933..83e1bb1 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -60,10 +60,10 @@ INSN_CONFIG instructions:
> insn.insn=INSN_CONFIG; //configuration instruction
> insn.n=1; //number of operation (must be 1)
> insn.data=&initialvalue; //initial value loaded into encoder
> - //during configuration
> + //during configuration

Why change this?

> insn.subdev=5; //encoder subdevice
> insn.chanspec=CR_PACK(encoder_channel,0,AREF_OTHER); //encoder_channel
> - //to configure
> + //to configure

Why is this line indented so much now?

Care to resend this without these changes?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-06-17 22:39    [from the cache]
©2003-2011 Jasper Spaans