Messages in this thread | | | Date | Thu, 17 Jun 2010 10:44:06 -0700 | From | Greg KH <> | Subject | Re: [PATCH 4/6] USB-BKL: Remove BKL use in uhci-debug |
| |
On Wed, Jun 02, 2010 at 02:11:53PM +0400, Sergei Shtylyov wrote: > Hello. > > Arnd Bergmann wrote: > > >From: Andi Kleen <ak@linux.intel.com> > > >BKL was not really needed, just came from earlier push downs. > > >The only part that's a bit dodgy is the lseek function. Would > >need another lock or atomic access to fpos on 32bit? > >Better to have a libfs lseek > > >Signed-off-by: Andi Kleen <ak@linux.intel.com> > > [...] > > >diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c > >index 98cf0b2..b0cf4f8 100644 > >--- a/drivers/usb/host/uhci-debug.c > >+++ b/drivers/usb/host/uhci-debug.c > > [...] > > >@@ -539,11 +534,11 @@ static loff_t uhci_debug_lseek(struct file *file, loff_t off, int whence) > > new = file->f_pos + off; > > break; > > } > >+ > >+ /* XXX: Can size shrink? */ > > if (new < 0 || new > up->size) { > >- unlock_kernel(); > > return -EINVAL; > > } > > Should have dropped {}...
I've fixed that up in the version that got applied.
thanks,
greg k-h
| |