Messages in this thread Patch in this message | | | Date | Thu, 17 Jun 2010 09:16:41 -0700 | From | "Justin P. Mattock" <> | Subject | Re: [PATCH 5/5]scsi:hosts.c Fix warning: variable 'rval' set but not used |
| |
> Erm, well, as I said, error code and the fact that the thread failed to > start, so more > > printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error > = %d\n", host->host_no, PTR_ERR(shost->ehandler)); > > James >
o.k. I looked at this a bit more and finally got the thing to build through without a warning, using what you had sent, but keep in mind I still need to add error = %d\n", host->host_no, to the printk
here's what I have so far:
drivers/scsi/hosts.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 6660fa9..c1ff708 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -419,8 +419,9 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
shost->ehandler = kthread_run(scsi_error_handler, shost, "scsi_eh_%d", shost->host_no); + rval = PTR_ERR(shost->ehandler); if (IS_ERR(shost->ehandler)) { - rval = PTR_ERR(shost->ehandler); + printk(KERN_WARNING "scsi%d: error handler thread failed to spawn\n", rval); goto fail_kfree; }
I'll continue to look at this today!! cheers,
Justin P. Mattock
| |