lkml.org 
[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH v3] drivers: regulator: add Maxim 8998 driver
Hello,

On Wednesday, June 16, 2010 4:31 PM Mark Brown wrote:

> On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote:
> > From: Kyungmin Park <kyungmin.park@samsung.com>
> >
> > This patch adds voltage regulator driver for Maxim 8998 chip. This chip
> > is used on Samsung Aquila and GONI boards and provides following
> > functionalities:
> > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power
> > controllers
> > - battery charger
> >
> > This patch adds basic driver for voltage regulators and MAX 8998 MFD core.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> Looks good!
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

I've just noticed one more thing. Shouldn't the max8998-pmic driver depend
on max8998 mfd driver in Kconfig? Or maybe it would be better to select mfd
driver from the regulators Kconfig? What do you think?

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center




\
 
 \ /
  Last update: 2010-06-17 15:39    [W:0.070 / U:2.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site