lkml.org 
[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: bnx2 fails to compile on parisc because of missing get_dma_ops()
    From
    On Wed, Jun 16, 2010 at 11:53 PM, Michael Chan wrote:
    > Mike Frysinger wrote:
    >> > The commit that causes the problem:
    >> >
    >> > commit a33fa66bcf365ffe5b79d1ae1d3582cc261ae56e
    >> > Author: Michael Chan <mchan@broadcom.com>
    >> > Date:   Thu May 6 08:58:13 2010 +0000
    >> >
    >> >    bnx2: Add prefetches to rx path.
    >> >
    >> > Looks fairly innocuous by the description.
    >> >
    >> > Should parisc have a get_dma_ops()?  We don't need one
    >> because our dma
    >> > ops are per platform not per bus.
    >>
    >> looks like it'll be broken on more than just parisc:
    >> $ grep get_dma_ops arch/*/include/asm/ -rl | cut -d/ -f 2
    >> alpha
    >> ia64
    >> microblaze
    >> powerpc
    >> sh
    >> sparc
    >> x86
    >
    > Most of these archs use the dma functions in:
    >
    > <asm-genric/dma-mapping-common.h>
    >
    > so it's not a problem.

    the grep is showing only the arches that define get_dma_ops (and so
    the new code works). you'd have to invert the list to see the ones
    which do not define get_dma_ops(), and the inverted list is larger.
    that was merely my point.
    -mike
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-17 06:03    [W:0.023 / U:65.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site