Messages in this thread | | | Date | Wed, 16 Jun 2010 12:28:04 -0700 | From | Charles Clément <> | Subject | Re: [PATCH 1/2] Staging: comedi: fix style errors in adl_pci9111.c |
| |
Hi,
On Wed, Jun 16, 2010 at 07:30:09PM +0100, John Sheehan wrote: > From: John Sheehan <john.d.sheehan@gmail.com>
> @@ -190,7 +190,7 @@ TODO: > outb(flags, PCI9111_IO_BASE+PCI9111_REGISTER_TRIGGER_MODE_CONTROL) > > #define pci9111_interrupt_and_fifo_get() \ > - ((inb(PCI9111_IO_BASE+PCI9111_REGISTER_AD_MODE_INTERRUPT_READBACK) >> 4) &0x03) > + ((inb(PCI9111_IO_BASE+PCI9111_REGISTER_AD_MODE_INTERRUPT_READBACK) >> 4)&0x03)
Doesn't checkpatch.pl suggest to add a whitespace after the & in that case? It would seem more readable.
-- Charles Clément
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |