Messages in this thread | | | Date | Wed, 16 Jun 2010 18:16:52 +0200 | From | Louis Rilling <> | Subject | Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early |
| |
On 16/06/10 20:04 +0400, Pavel Emelyanov wrote: > > +void proc_new_task(struct task_struct *task) > > +{ > > + struct pid *pid; > > + int i; > > + > > + if (!task->pid) > > + return; > > + > > + pid = task_pid(task); > > + for (i = 0; i <= pid->level; i++) > > + mntget(pid->numbers[i].ns->proc_mnt); > > I feel I'm missing something significant, but this patch breaks > the mntget/mntput balance. Doesn't it?
Gah. Sorry, the part in proc_flush_task() is missing. Will resend ASAP.
Thanks,
Louis
> > > +} > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Dr Louis Rilling Kerlabs Skype: louis.rilling Batiment Germanium Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de Coesmes http://www.kerlabs.com/ 35700 Rennes
| |