lkml.org 
[lkml]   [2010]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86-32: remove CONFIG_4KSTACKS
On Wed, Jun 16, 2010 at 11:21:36AM +0100, Alan Cox wrote:
> On Wed, 16 Jun 2010 11:16:21 +0200
> Christoph Hellwig <hch@lst.de> wrote:
>
> > These days 4 kilobytes of stack just aren't enough for reliably operation,
> > and people using lots of threads have long switched to x86-64, so remove the
> > CONFIG_4KSTACKS option.
>
> It's very useful for things like debugging and because of the split
> kernel/irq stacks.

Ingo just ACKed my previous patch to make irq stacks unconditional.

> It also seems to be quite adequate for most
> configurations.

See the direct reclaim flamewar. Currently we can end up in ->writepage
from af_unix poll code with over 3k stack alreay used. It's certainly
not anywhere near enough.

> Perhaps XFS should select 8K stack instead ?

or rather !CONFIG_INSANE. I don't care too much. No one sane should
ever enable it anymore, but Ingo asked me to send a patch to remove it.


\
 
 \ /
  Last update: 2010-06-16 12:23    [from the cache]
©2003-2011 Jasper Spaans