lkml.org 
[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2] matrix_keypad: add support for clustered irq
Date
On Thursday, May 27, 2010 08:14:50 am Eric Miao wrote:
> On Thu, May 27, 2010 at 2:43 PM, Luotao Fu <l.fu@pengutronix.de> wrote:
> > This one adds support of a combined irq source for the whole matrix keypad.
> > This can be useful if all rows and columns of the keypad are e.g. connected
> > to a GPIO expander, which only has one interrupt line for all events on
> > every single GPIO.
> >
> > Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
>
> I feel OK. Acked-by: Eric Miao <eric.y.miao@gmail.com>
>
> > ---
> > V2 Changes:
> > * create separate functions for suspend/resume calls.
> > * add bool flag to signal enable/disable state of all gpios.
> > * add spinlock to suspend and resume callbacks.

The spinlock is not needed, it should be OK to get interrupted in the middle
of setting up wakeup sources. The enable/disable irq is different as if we
get interrupted in the middle of the process our counters will get messed
up.

Fixed a few compile warnings and applied for .36.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2010-06-15 05:17    [W:0.052 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site