lkml.org 
[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe:
    On 06/14/2010 04:22 PM, Stefan Richter wrote:
    > which caused gcc 4.6 to warn about
    > variable 'destination' set but not used.
    >
    > Reported-by: Justin P. Mattock<justinmattock@gmail.com>
    >
    > Since the hardware ensures that we receive only response packets with
    > proper destination node ID (in a given bus generation), we have no use
    > for destination here in the core as well as in upper layers.
    >
    > (This is different with request packets. There we pass destination node
    > ID to upper layers because they may for example need to check whether
    > this was an unicast or broadcast request.)
    >
    > Signed-off-by: Stefan Richter<stefanr@s5r6.in-berlin.de>
    > ---
    > drivers/firewire/core-transaction.c | 11 +++++------
    > 1 file changed, 5 insertions(+), 6 deletions(-)
    >
    > Index: b/drivers/firewire/core-transaction.c
    > ===================================================================
    > --- a/drivers/firewire/core-transaction.c
    > +++ b/drivers/firewire/core-transaction.c
    > @@ -881,13 +881,12 @@ void fw_core_handle_response(struct fw_c
    > unsigned long flags;
    > u32 *data;
    > size_t data_length;
    > - int tcode, tlabel, destination, source, rcode;
    > + int tcode, tlabel, source, rcode;
    >
    > - tcode = HEADER_GET_TCODE(p->header[0]);
    > - tlabel = HEADER_GET_TLABEL(p->header[0]);
    > - destination = HEADER_GET_DESTINATION(p->header[0]);
    > - source = HEADER_GET_SOURCE(p->header[1]);
    > - rcode = HEADER_GET_RCODE(p->header[1]);
    > + tcode = HEADER_GET_TCODE(p->header[0]);
    > + tlabel = HEADER_GET_TLABEL(p->header[0]);
    > + source = HEADER_GET_SOURCE(p->header[1]);
    > + rcode = HEADER_GET_RCODE(p->header[1]);
    >
    > spin_lock_irqsave(&card->lock, flags);
    > list_for_each_entry(t,&card->transaction_list, link) {
    >


    built good.. here's what I see now:

    LD kernel/built-in.o
    CC [M] fs/reiserfs/stree.o
    LD [M] fs/reiserfs/reiserfs.o
    CC [M] drivers/firewire/core-transaction.o
    LD [M] drivers/firewire/firewire-core.o
    LD [M] drivers/firewire/firewire-ohci.o
    LD [M] drivers/firewire/firewire-sbp2.o
    CC [M] drivers/ieee1394/sbp2.o
    CC [M] drivers/net/wireless/hostap/hostap_80211_rx.o
    CC [M] drivers/net/wireless/hostap/hostap_80211_tx.o
    CC [M] drivers/net/wireless/hostap/hostap_ap.o

    nice and clean!!

    Reported-and-Tested-By: Justin P. Mattock <justinmattock@gmail.com>

    Justin P. Mattock


    \
     
     \ /
      Last update: 2010-06-15 02:01    [W:0.027 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site