lkml.org 
[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET] workqueue: concurrency managed workqueue, take#5
On Tue, 15 Jun 2010 00:17:25 +0200
Tejun Heo <tj@kernel.org> wrote:

> On 06/14/2010 11:58 PM, Andrew Morton wrote:
> > On Mon, 14 Jun 2010 23:37:17 +0200
> > Tejun Heo <tj@kernel.org> wrote:
> >
> >> This is the fifth take of cmwq (concurrency managed workqueue)
> >> patchset.
> >
> > What is a concurrency managed workqueue and why do we want one?
>
> That goes back about 9 month. You were cc'd there too. :-)
>
> http://thread.gmane.org/gmane.linux.kernel/896268
>

Nobody's going to remember all that stuff except yourself, and the info
might be out of date. So please update and maintain that information
and retain it with the patchset.

eg: "<NEED SOME BACKING NUMBERS>". And "Please read the patch
description of the last patch for more details" is out of date.

Because right now I have a bunch of code in my inbox and little
(actually "no") idea why anyone might want to merge it into anything.

Trying to review a large patchset when you don't have an overall
picture of what it's trying to do and how it's trying to do it is
rather painful - you have to work all that stuff out from the
implementation. It's also error-prone if the implementation doesn't
implement that which the author thinks it implements (ie: if it has
design bugs).



\
 
 \ /
  Last update: 2010-06-15 00:39    [from the cache]
©2003-2011 Jasper Spaans