[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings
> > > function head comment during development.  Anyway, if we do get an
> > > error here, we cannot handle it anyway - it's too late to do
> > > anything short of a complete shutdown as we've already written the
> > > transaction to the log.
> >
> > Well I guess it should be unconditional BUG_ON then.
> Don't be silly. A filesystem shutdown is all that is necessary,

Without BUG_ON it will not end up in and you will
never know about it. That's standard Linux kernel development

Maybe XFS should catch up on that.

Ok in principle you could make the shutdown a WARN()

Anyways I'm out of this.

-- -- Speaking for myself only.

 \ /
  Last update: 2010-06-14 16:39    [W:0.050 / U:0.592 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site