lkml.org 
[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3 V2] gpio: add STMPE811 gpio controller support
    Hi Mark,

    thaks for the review.

    On Mon, Jun 14, 2010 at 12:51:23PM +0100, Mark Brown wrote:
    > On Mon, Jun 14, 2010 at 12:32:37PM +0200, Luotao Fu wrote:
    >
    > > +static struct gpio_chip gpio_chip = {
    > > + .label = STMPE811_GPIO_NAME,
    > > + .owner = THIS_MODULE,
    > > + .direction_input = stmpe811_gpio_direction_in,
    > > + .get = stmpe811_gpio_get,
    > > + .direction_output = stmpe811_gpio_direction_out,
    > > + .set = stmpe811_gpio_set,
    > > + .request = stmpe811_gpio_request,
    > > + .can_sleep = 1,
    > > +};
    >
    > Assuming you're able to do interrupts on the GPIOs you should now be
    > able to implement to_irq() as well.

    The chip can indeed generate irqs on the GPIO line. I, however, kept out
    the irq stuff for now because i want to get the core functionalies done
    for this turn. I'd like to add the irq stuff with a separate patch later.

    Thanks

    cheers
    Luotao Fu
    --
    Pengutronix e.K. | Dipl.-Ing. Luotao Fu |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-06-14 14:13    [W:0.048 / U:92.856 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site