Messages in this thread | | | Date | Mon, 14 Jun 2010 13:21:50 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH V2 0/4] Add MMC erase and secure erase |
| |
On Mon, Jun 14, 2010 at 02:10:06PM +0300, Adrian Hunter wrote: > Needs a bio flag, a request flag, setup the request flag based on the > bio flag, prevent merging secure and non-secure discards, prevent drivers > doing non-secure discards for secure discards. > > Seems like a lot of little changes for something that no one wants. > Shouldn't it wait for someone to need it first?
I know that some people have asked for this. But if you want to keep it in the driver for now that's fine to me. But in that case please:
(a) make it entirely driver private and leave no traces of it in the block layer (b) split it into a separate patch from the discard support
| |