Messages in this thread | | | Subject | BUG: aim7/specjbb2005/fio hang due to commit: 597a264b1a9c7e36d1728f | From | "Alex,Shi" <> | Date | Sun, 13 Jun 2010 14:14:00 +0800 |
| |
The listed benchmark using loopback mode netio and all hang in 35-rc3 testing. Yanmin and I found it is due to the commit 597a264b1a9c7e36d1728f677c66c5c1f7e3b837. After revert this patch, all benchmarks can be recovered. Seems the following line is the suspicious.
+ /* + * bonding note: skbs received on inactive slaves should only + * be delivered to pkt handlers that are exact matches. Also + * the deliver_no_wcard flag will be set. If packet handlers + * are sensitive to duplicate packets these skbs will need to + * be dropped at the handler. The vlan accel path may have + * already set the deliver_no_wcard flag. + */ null_or_orig = NULL; orig_dev = skb->dev; master = ACCESS_ONCE(orig_dev->master); - if (master) { - if (skb_bond_should_drop(skb, master)) + if (skb->deliver_no_wcard) + null_or_orig = orig_dev; + else if (master) { + if (skb_bond_should_drop(skb, master)) { + skb->deliver_no_wcard = 1; null_or_orig = orig_dev; /* deliver only exact match */ - else + } else skb->dev = master; }
Thanks Alex
| |