lkml.org 
[lkml]   [2010]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 3/7] KVM: MMU: avoid double write protected in sync page path
    The sync page is already write protected in mmu_sync_children(), don't
    write protected it again

    Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
    ---
    arch/x86/kvm/mmu.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)
    diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
    index 21ab85b..2ffd673 100644
    --- a/arch/x86/kvm/mmu.c
    +++ b/arch/x86/kvm/mmu.c
    @@ -1216,6 +1216,7 @@ static void kvm_mmu_commit_zap_page(struct kvm *kvm,
    if ((sp)->gfn != (gfn) || (sp)->role.direct || \
    (sp)->role.invalid) {} else

    +/* @sp->gfn should be write-protected at the call site */
    static int __kvm_sync_page(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp,
    struct list_head *invalid_list, bool clear_unsync)
    {
    @@ -1224,11 +1225,8 @@ static int __kvm_sync_page(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp,
    return 1;
    }

    - if (clear_unsync) {
    - if (rmap_write_protect(vcpu->kvm, sp->gfn))
    - kvm_flush_remote_tlbs(vcpu->kvm);
    + if (clear_unsync)
    kvm_unlink_unsync_page(vcpu->kvm, sp);
    - }

    if (vcpu->arch.mmu.sync_page(vcpu, sp)) {
    kvm_mmu_prepare_zap_page(vcpu->kvm, sp, invalid_list);
    --
    1.6.1.2



    \
     
     \ /
      Last update: 2010-06-11 15:37    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean