Messages in this thread | | | Date | Fri, 11 Jun 2010 14:02:36 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] drivers: regulator: add Maxim 8998 driver |
| |
On Fri, Jun 11, 2010 at 02:55:07PM +0200, Marek Szyprowski wrote: > On Friday, June 11, 2010 12:58 PM Mark Brown wrote:
> > A few things in the code make it look like the driver should be using > > the MFD framework - there's references in here for things like a battery > > charger which should be being supported via the power subsystem, for > > example.
> You are right, this chip is really complicated and should work with more > than one kernel subsystem. However in this initial version of the driver > we tried to make it as simple as possible. It can be converted to MFD > framework later, but if you want we can prepare this driver as MFD from > the beginning.
It makes life a lot easier to start off with the MFD, even if you only add a single function driver initially. Otherwise you end up with cross tree hassle trying to deal with the transiton later on.
| |