lkml.org 
[lkml]   [2010]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix Oops in crash_shrink_memory
On Wed, 09 Jun 2010 11:57:14 +0530
Pavan Naregundi <pavan@linux.vnet.ibm.com> wrote:

> Resending the patch with fixed style issues.
>
> Signed-off-by: Pavan Naregundi <pavan@linux.vnet.ibm.com>
> Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
> --
>
>
>
>
> [fix-kexec.patch text/x-patch (685B)]
> diff -Naur a/kernel/kexec.c b/kernel/kexec.c
> --- a/kernel/kexec.c 2010-06-08 21:17:21.850000033 +0530
> +++ b/kernel/kexec.c 2010-06-09 18:01:37.590007921 +0530
> @@ -1089,9 +1089,10 @@
>
> size_t crash_get_memory_size(void)
> {
> - size_t size;
> + size_t size = 0;
> mutex_lock(&kexec_mutex);
> - size = crashk_res.end - crashk_res.start + 1;
> + if (crashk_res.end != crashk_res.start)
> + size = crashk_res.end - crashk_res.start + 1;
> mutex_unlock(&kexec_mutex);
> return size;
> }
> @@ -1134,7 +1135,7 @@
>
> free_reserved_phys_range(end, crashk_res.end);
>
> - if (start == end)
> + if ((start == end) && (crashk_res.parent != NULL))
> release_resource(&crashk_res);
> crashk_res.end = end - 1;

The patch doesn't have a changelog and I'd prefer not to have to crawl
through the email thread and write one myself.

Please resend, including a full description of the bug and of its fix.


\
 
 \ /
  Last update: 2010-06-10 23:29    [W:0.061 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site