Messages in this thread | | | Date | Thu, 10 Jun 2010 18:22:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 02/13] jump label v9: base patch |
| |
* Jason Baron <jbaron@redhat.com> wrote:
> > > + entry = add_jump_label_entry((char *)iter_begin->name, > > > + count, iter_begin); > > > + if (IS_ERR(entry)) > > > + return PTR_ERR(entry); > > > + continue; > > > + } > > > + WARN(1, KERN_ERR "build_jump_hashtable: unexpected entry!\n"); > > > > > > > > It seems you are going to endless loop in this fail case. > > > > agreed. I need to stick that 'WARN' into the else clause of "if > (!entry)" and return an error.
and make that WARN_ONCE() as well. If it ever triggers it should show up once and not compound the bug with spamming the console and the logs.
Thanks,
Ingo
| |