Messages in this thread | | | Date | Thu, 10 Jun 2010 15:56:10 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] sa1111: Prevent deadlock in resume path |
| |
On Wed 2010-05-26 21:18:24, Russell King - ARM Linux wrote: > On Wed, May 26, 2010 at 09:15:57PM +0200, Marek Vasut wrote: > > Dne St 26. května 2010 21:14:25 Russell King - ARM Linux napsal(a): > > > On Wed, May 26, 2010 at 09:11:44PM +0200, Marek Vasut wrote: > > > > This patch reorganises the sa1111_resume() function in a manner the > > > > spinlock happens after calling the sa1111_wake(). This fixes two bugs: > > > > > > > > 1) This function called sa1111_wake() which tried to claim the same > > > > spinlock > > > > > > > > the sa1111_resume() already claimed. This would result in certain > > > > deadlock. > > > > > > > > Original idea for this part: Russell King <linux@arm.linux.org.uk> > > > > > > > > 2) The function didn't unlock the spinlock in case the chip didn't report > > > > > > > > correct ID. > > > > > > > > Original idea for this part: Julia Lawall <julia@diku.dk> > > > > > > > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> > > > > > > Yea, good enough. > > > > You want me to fight your patch tracking system or will you just merge it into > > your tree ? > > What do you mean "fight" ? Just send a standard git formatted patch > to the email address with an additional KernelVersion: tag. It's > not at all hard.
You are linux kernel maintainer. Start acting as one. It is not at all hard.
Alternatively, just remove KernelVersion: checking in your scripts.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |