lkml.org 
[lkml]   [2010]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/9] PM / Hibernate: swap, switch to hibernate_io_handle
    Hi!

    > I addressed the comments I got on the previous RFC. I left the handles
    > in place, the functions in hibernate_io_ops now works on them. Further
    > I got rid of the memory barriers and minimized global variables as much
    > as possible. Comments welcome.

    It would be good if you carried ack-s from previous rounds, so that I
    don't have to review good patches again...

    > Some code, which will be moved out of swap.c, will know nothing about
    > swap. There will be also other than swap writers later, so that it
    > won't make sense at all.
    >
    > So introduce a new structure called hibernate_io_handle which
    > currently contains only a pointer to private data, but is independent
    > on I/O reader/writer actually used. Private data are swap_map_handle
    > for now.
    >
    > This structure is allocated in _start and freed in _finish. This will
    > correspond to the later introduction of hibernate_io_ops where users
    > will do handle=start->repeat{read/write(handle)}->finish(handle).
    > I.e. they will operate on handle instead of global variables.
    >
    > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    > Cc: "Rafael J. Wysocki" <rjw@sisk.pl>

    ack.

    > +/**
    > + * hib_io_handle_alloc - allocate io handle with priv_size for private data
    > + *
    > + * @priv_size: the sie to allocate behind hibernate_io_handle for private use
    > + */
    > +static inline struct hibernate_io_handle *hib_io_handle_alloc(size_t priv_size)
    > +{
    > + struct hibernate_io_handle *ret;
    > + ret = kzalloc(sizeof(*ret) + priv_size, GFP_KERNEL);
    > + if (ret)
    > + ret->priv = ret + 1;

    Uhuh, why this? Aha, grabbing the pointer to priv_size-sized area at
    the end of regular struct?

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2010-06-10 15:59    [W:0.022 / U:0.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site