lkml.org 
[lkml]   [2010]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] vhost: apply cpumask and cgroup to vhost workers
On 06/01/2010 07:19 PM, Sridhar Samudrala wrote:
>> - int i;
>> + cpumask_var_t mask;
>> + int i, ret = -ENOMEM;
>> +
>> + if (!alloc_cpumask_var(&mask, GFP_KERNEL))
>> + goto out_free_mask;
>
> I think this is another bug in the error path. You should simply
> do a return instead of a goto here when aloc_cpu_mask fails.

Oh... it's always safe to call free_cpumask_var() after failed
alloc_cpumask_var(), so that part isn't broken.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-06-02 02:03    [from the cache]
©2003-2011 Jasper Spaans