Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH 1/6] USB-BKL: Remove lock_kernel in usbfs update_sb() | Date | Tue, 1 Jun 2010 23:04:40 +0200 |
| |
From: Andi Kleen <ak@linux.intel.com>
The code this is attempting to lock against does not use the BKL, so it's not needed.
Most likely this code is still broken/racy (Al Viro also thinks so), but removing the BKL should not make it worse than before.
Signed-off-by: Andi Kleen <ak@linux.intel.com> --- drivers/usb/core/inode.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c index 1a27618..095fa53 100644 --- a/drivers/usb/core/inode.c +++ b/drivers/usb/core/inode.c @@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data) return -EINVAL; } - lock_kernel(); - if (usbfs_mount && usbfs_mount->mnt_sb) update_sb(usbfs_mount->mnt_sb); - unlock_kernel(); - return 0; } -- 1.7.0.4
| |