Messages in this thread | | | Date | Tue, 1 Jun 2010 15:53:10 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL) |
| |
On Mon, 31 May 2010 14:55:48 +0200, Wolfram Sang wrote: > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > devices are not really unregistered, but merely detached from their driver, it > used to be the drivers obligation to clear this pointer during remove() or a > failed probe(). As a couple of drivers forgot to do this, it was agreed that it > was cleaner if the i2c-core does this clearance when appropriate, as there is > no guarantee for the lifetime of the clientdata-pointer after remove() anyhow. > This feature was added to the core with commit > e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers. > > As there is no need anymore to clear the clientdata-pointer, remove all current > occurrences in the drivers to simplify the code and prevent confusion. > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > Cc: Jean Delvare <khali@linux-fr.org> > (...)
Applied, thanks. Will go to Linus in the next few days.
-- Jean Delvare
| |