Messages in this thread | | | Date | Sat, 08 May 2010 14:47:05 +0200 | From | Tejun Heo <> | Subject | Re: [GIT PULL sched/core] cpu_stop: implement and use cpu_stop, take#3 |
| |
Hello, Ingo.
On 05/08/2010 01:15 PM, Ingo Molnar wrote: > FYI, it doesnt build on x86 allnoconfig: > > kernel/sched_fair.c: In function 'load_balance': > kernel/sched_fair.c:2917: error: implicit declaration of function 'stop_one_cpu_nowait' > kernel/sched.c: In function 'sched_exec': > kernel/sched.c:3084: error: implicit declaration of function 'stop_one_cpu' > kernel/sched.c: In function 'synchronize_sched_expedited':
The commit is fc390cde362309f6892bb719194f242c466a978b, right? Yeah, it's missing the dummy definitions for UP. The strange thing is that the commit builds fine w/ allnoconfig on x86 and x86_64. Ah... maybe other changes in sched/core makes use of stop_cpu*() from UP code path. Anyways, will fix it right away.
Thanks.
-- tejun
| |