Messages in this thread Patch in this message | | | From | Hitoshi Mitake <> | Subject | [PATCH] perf lock: Drop "-a" option from set of default arguments to cmd_record() | Date | Sat, 8 May 2010 17:10:29 +0900 |
| |
This patch drops "-a" from record_args, which is passed to cmd_record().
Even if user wants to record all lock events during process runs, perf lock record -a <program> <argument> ... is enough for this purpose.
This can reduce size of perf.data.
% sudo ./perf lock record whoami root [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.439 MB perf.data (~19170 samples) ] % sudo ./perf lock record -a whoami # with -a option root [ perf record: Woken up 0 times to write data ] [ perf record: Captured and wrote 48.962 MB perf.data (~2139197 samples) ]
This patch was made on perf/test of random-tracing.git, could you queue this, Frederic?
Cc: Ingo Molnar <mingo@elte.hu> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jens Axboe <jens.axboe@oracle.com> Cc: Jason Baron <jbaron@redhat.com> Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
--- tools/perf/builtin-lock.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c index d7dde9c..7f72abc 100644 --- a/tools/perf/builtin-lock.c +++ b/tools/perf/builtin-lock.c @@ -930,7 +930,6 @@ static const struct option lock_options[] = { static const char *record_args[] = { "record", - "-a", "-R", "-f", "-m", "1024", -- 1.6.5.2
| |