lkml.org 
[lkml]   [2010]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] get_maintainer.pl: optionally ignore non-maintainer tags
Date
Using --git to determine who to send a patch to, it is not
reasonable to include people that only reported an issue or tested a
patch. Thus we restrict the candidates to be the one's listed with
Reviewed-By, Signed-Off-By and Acked-By tags.

Signed-Off-By:'s because that are people who are responsible for the code
in question.

Reviewed-By:'s because people responsible for the code in question
obviously thought that the review-feedback for this changeset by that
person was valuable.

The Acked-By: is questionable, but as people listed with this tag
tend to be active linux gatekeepers, false positives are tolerable.

Signed-off-by: Florian Mickler <florian@mickler.org>
---
scripts/get_maintainer.pl | 21 ++++++++++++++++++++-
1 files changed, 20 insertions(+), 1 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 6f97a13..8e974bb 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -25,6 +25,7 @@ my $email_list = 1;
my $email_subscriber_list = 0;
my $email_git_penguin_chiefs = 0;
my $email_git = 1;
+my $email_git_maintainers = 0;
my $email_git_blame = 0;
my $email_git_min_signatures = 1;
my $email_git_max_maintainers = 5;
@@ -50,6 +51,15 @@ my $help = 0;

my $exit = 0;

+#
+# tags for people who are either
+# a) responsible for the code in question, or
+# b) familiar enough with it to give relevant feedback
+my @maintainer_tags = ();
+push(@maintainer_tags,"Signed-Off");
+push(@maintainer_tags,"Reviewed");
+push(@maintainer_tags,"Acked");
+
my @penguin_chief = ();
push(@penguin_chief,"Linus Torvalds:torvalds\@linux-foundation.org");
#Andrew wants in on most everything - 2009/01/14
@@ -100,6 +110,7 @@ my %VCS_cmds_hg = (
if (!GetOptions(
'email!' => \$email,
'git!' => \$email_git,
+ 'git-maintainers!' => \$email_git_maintainers,
'git-blame!' => \$email_git_blame,
'git-chief-penguins!' => \$email_git_penguin_chiefs,
'git-min-signatures=i' => \$email_git_min_signatures,
@@ -497,6 +508,7 @@ version: $V
MAINTAINER field selection options:
--email => print email address(es) if any
--git => include recent git \*-by: signers
+ --git-maintainers => only use 'Signed-Off-By:', 'Reviewed-By:' and 'Acked-By:' signers
--git-chief-penguins => include ${penguin_chiefs}
--git-min-signatures => number of signatures required (default: 1)
--git-max-maintainers => maximum maintainers to add (default: 5)
@@ -957,6 +969,13 @@ sub vcs_find_signers {
my ($cmd) = @_;
my @lines = ();
my $commits;
+ my $tagPattern;
+ if ($email_git_maintainers) {
+ $tagPattern = join("|",@maintainer_tags);
+ } else {
+ $tagPattern = "[^ \t]+";
+ }
+

@lines = &{$VCS_cmds{"execute_cmd"}}($cmd);

@@ -964,7 +983,7 @@ sub vcs_find_signers {

$commits = grep(/$pattern/, @lines); # of commits

- @lines = grep(/^[-_ a-z]+by:.*\@.*$/i, @lines);
+ @lines = grep(/^[ \t]*($tagPattern)-by:.*\@.*$/i, @lines);
if (!$email_git_penguin_chiefs) {
@lines = grep(!/${penguin_chiefs}/i, @lines);
}
--
1.7.0.4


\
 
 \ /
  Last update: 2010-05-08 23:37    [W:0.100 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site