lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [PATCH] Check kmalloc return value before use the buffer
    From
    Oh,I think I have a mistake


    Signed-off-by: root <root@T-bagwell.(none)>
    ---
    arch/arm/mach-u300/dummyspichip.c | 5 +++++
    1 files changed, 5 insertions(+), 0 deletions(-)

    diff --git a/arch/arm/mach-u300/dummyspichip.c
    b/arch/arm/mach-u300/dummyspichip.c
    index 5f55012..df19f9b 100644
    --- a/arch/arm/mach-u300/dummyspichip.c
    +++ b/arch/arm/mach-u300/dummyspichip.c
    @@ -64,6 +64,11 @@ static ssize_t dummy_looptest(struct device *dev,
    goto out;
    }
    bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
    + if (bigrxbuf_virtual == NULL) {
    + status = -ENOMEM;
    + kfree(bigtxbuf_virtual);
    + goto out;
    + }

    /* Fill TXBUF with some happy pattern */
    memset(bigtxbuf_virtual, 0xAA, DMA_TEST_SIZE);
    --
    1.6.0.3




    what a bout this one, please?


    Best regards!



    2010/5/7 Linus WALLEIJ <linus.walleij@stericsson.com>:
    > Hi Liu,
    >
    >> Hi,linus.walleij
    >>
    >>           Check kmalloc return value before use the buffer
    >>
    >>
    >> Signed-off-by: LiuQi <lingjiujianke@gmail.com>
    >> ---
    >>  arch/arm/mach-u300/dummyspichip.c |    5 +++++
    >>  1 files changed, 5 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/arch/arm/mach-u300/dummyspichip.c
    >> b/arch/arm/mach-u300/dummyspichip.c
    >> index 962f9de..4f2af7c 100644
    >> --- a/arch/arm/mach-u300/dummyspichip.c
    >> +++ b/arch/arm/mach-u300/dummyspichip.c
    >> @@ -63,6 +63,11 @@ static ssize_t dummy_looptest(struct device *dev,
    >>               goto out;
    >>       }
    >>       bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
    >> +     if (bigtxbuf_virtual == NULL) {
    >> +             status = -ENOMEM;
    >> +             kfree(bigtxbuf_virtual);
    >
    > kfree():ing NULL is OK, but you just checked it to be NULL so why?
    >
    >> +             goto out;
    >> +     }
    >>
    >>       /* Fill TXBUF with some happy pattern */
    >>       memset(bigtxbuf_virtual, 0xAA, DMA_TEST_SIZE);
    >
    > Otherwise the bug it fixes is good to fix.
    >
    > Yours,
    > Linus Walleij
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-07 09:19    [W:0.025 / U:61.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site