lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v21 053/100] c/r (ipc): allow allocation of a desired ipc identifier


Manfred Spraul wrote:
> Hi Oren,
>
>
> On 05/01/2010 04:15 PM, Oren Laadan wrote:
>> @@ -82,7 +82,7 @@ void shm_init_ns(struct ipc_namespace *ns)
>> * Called with shm_ids.rw_mutex (writer) and the shp structure locked.
>> * Only shm_ids.rw_mutex remains locked on exit.
>> */
>> -static void do_shm_rmid(struct ipc_namespace *ns, struct
>> kern_ipc_perm *ipcp)
>> +void do_shm_rmid(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
>> {
>> struct shmid_kernel *shp;
>> shp = container_of(ipcp, struct shmid_kernel, shm_perm);
>>
> This hunk appears to be unrelated to the main patch.
> Is it intentional or a left-over from debugging?
>

Good catch: it belongs in patch 55: "c/r: support shared memory
sysv-ipc". Will move it there. Thanks for the review.

Oren.



\
 
 \ /
  Last update: 2010-05-07 19:11    [W:0.386 / U:2.920 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site