Messages in this thread Patch in this message | | | Date | Fri, 07 May 2010 13:58:04 +0800 | From | Li Zefan <> | Subject | [PATCH v2 7/8] xconfig: clean up |
| |
@ok is a pointer to a bool var, so we should check the value of *ok. But actually we don't need to check it, so just remove the if statement.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- scripts/kconfig/qconf.cc | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index 00c5150..47cdeae 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -58,11 +58,10 @@ QValueList<int> ConfigSettings::readSizes(const QString& key, bool *ok) { QValueList<int> result; QStringList entryList = readListEntry(key, ok); - if (ok) { - QStringList::Iterator it; - for (it = entryList.begin(); it != entryList.end(); ++it) - result.push_back((*it).toInt()); - } + QStringList::Iterator it; + + for (it = entryList.begin(); it != entryList.end(); ++it) + result.push_back((*it).toInt()); return result; } -- 1.6.3
| |