lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch]hp_accel: Fix race in device removal
    Op 07-05-10 18:04, Oliver Neukum schreef:
    > From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
    > From: Oliver Neukum <oliver@neukum.org>
    > Date: Fri, 7 May 2010 18:02:07 +0200
    > Subject: [PATCH] hp_accel: Fix race in device removal
    >
    > The work queue has to be flushed after the device has been made
    > inaccessible.
    >
    > Signed-off-by: Oliver Neukum <oneukum@suse.de>
    Ah, flushing the work before unregistering the device seemed more
    logical... but now that you mention it, I understand the race.

    Thanks

    Acked-by: Eric Piel <eric.piel@tremplin-utc.net>


    > ---
    > drivers/hwmon/hp_accel.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
    > index c8ab505..7580f55 100644
    > --- a/drivers/hwmon/hp_accel.c
    > +++ b/drivers/hwmon/hp_accel.c
    > @@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
    > lis3lv02d_joystick_disable();
    > lis3lv02d_poweroff(&lis3_dev);
    >
    > - flush_work(&hpled_led.work);
    > led_classdev_unregister(&hpled_led.led_classdev);
    > + flush_work(&hpled_led.work);
    >
    > return lis3lv02d_remove_fs(&lis3_dev);
    > }



    \
     
     \ /
      Last update: 2010-05-07 18:13    [W:0.025 / U:0.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site