Messages in this thread | | | Date | Fri, 07 May 2010 19:51:39 +1000 | From | Nigel Cunningham <> | Subject | Re: [PATCH] Check kmalloc return value before use the buffer |
| |
Hi.
On 07/05/10 19:47, Steven Liu wrote: > Hi, guy, > > the code in arch/arm/mach-u300/dummyspichip.c is > > bigtxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL); > if (bigtxbuf_virtual == NULL) { > status = -ENOMEM; > goto out; > } > bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL); > > > if kmalloc memory space for bigrxbuf_virtual is NULL, when it have > kmalloc DMA_TEST_SIZE memory space for bigtxbuf_virtual,so ,if kmalloc > memory for bigtxbuf_virtual success and kmalloc memory for > bigrxbuf_virtual faild,i think we must kfree bigtxbuf_virtual memory
Ah, I see. I misread. Humble apologies :)
The other point still applies: You need to add a commit comment - even a simple one.
Regards,
Nigel
| |