lkml.org 
[lkml]   [2010]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] perf lock: add "info" subcommand for dumping misc information
On 05/06/10 06:10, Frederic Weisbecker wrote:
> On Mon, May 03, 2010 at 02:12:00PM +0900, Hitoshi Mitake wrote:
>> Hi Frederic,
>>
>> I added "info" subcommand to perf lock,
>> this can be used as dumping metadata like thread or address of lock
instances.
>> "map" was removed because info should do the work of it.
>>
>> This will be useful not only for debugging but also for ordinary
analyzing.
>>
>> I made this patch on perf/core of your tree, could you queue this?
>>
>> v2: adding example of usage
>> % sudo ./perf lock info -t
>> | Thread ID: comm
>> | 0: swapper
>> | 1: init
>> | 18: migration/5
>> | 29: events/2
>> | 32: events/5
>> | 33: events/6
>> ...
>>
>> % sudo ./perf lock info -m
>> | Address of instance: name of class
>> | 0xffff8800b95adae0:&(&sighand->siglock)->rlock
>> | 0xffff8800bbb41ae0:&(&sighand->siglock)->rlock
>> | 0xffff8800bf165ae0:&(&sighand->siglock)->rlock
>> | 0xffff8800b9576a98:&p->cred_guard_mutex
>> | 0xffff8800bb890a08:&(&p->alloc_lock)->rlock
>> | 0xffff8800b9522a08:&(&p->alloc_lock)->rlock
>> | 0xffff8800bb8aaa08:&(&p->alloc_lock)->rlock
>> | 0xffff8800bba72a08:&(&p->alloc_lock)->rlock
>> | 0xffff8800bf18ea08:&(&p->alloc_lock)->rlock
>> | 0xffff8800b8a0d8a0:&(&ip->i_lock)->mr_lock
>> | 0xffff88009bf818a0:&(&ip->i_lock)->mr_lock
>> | 0xffff88004c66b8a0:&(&ip->i_lock)->mr_lock
>> | 0xffff8800bb6478a0:&(shost->host_lock)->rlock
>>
>> v3: fixed some problems Frederic pointed out
>> * better rbtree tracking in dump_threads()
>> * removed printf() and used pr_info() and pr_debug()
>
>
>
> Applied, thanks Hitoshi!
>

Thanks Frederic!

And I prepared another patch for tracking only specified threads.

I'll send the new patch in this thread later.
But, the new one is not so big and hardly depends on "info -t" patch.
If you think the new patch and previous one should be in single patch,
please tell me. I'll merge them.

Thanks,
Hitoshi


\
 
 \ /
  Last update: 2010-05-06 11:33    [W:1.248 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site