Messages in this thread | | | Date | Wed, 05 May 2010 09:59:26 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] ubi: init even if mtd device cannot be attached, if built into kernel |
| |
Artem Bityutskiy wrote: > On Wed, 2010-05-05 at 08:12 +0300, Artem Bityutskiy wrote: >>> +#ifdef CONFIG_MTD_UBI_MODULE >>> +static inline int ubi_is_module(void) { return 1; } >>> +#else >>> +static inline int ubi_is_module(void) { return 0; } >>> +#endif >> I really hate these ifdefs. Dunno why, but they feel disgusting. >> >> I understand your issue and agree that is should be fixed. And I cannot >> really see a better solution. So if no-one complains, I'll accept your >> patch. >> >> However, for consistency with other UBI code (see debug.h), please, do >> this like >> >> #ifdef CONFIG_MTD_UBI_MODULE >> #define ubi_is_module() 1 >> #else >> #define ubi_is_module() 1 >> #endif > > Err, of course the second one should be 0, not 1. I can actually do this > modification myself, or you can re-send your patch.
I'll resend a patch.
Cheers, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |