Messages in this thread | | | Date | Wed, 5 May 2010 15:51:39 -0700 | From | Greg KH <> | Subject | Re: [PATCH 10/13] tty: untangle locking of wait_until_sent |
| |
On Wed, May 05, 2010 at 08:59:05PM +0100, Alan Cox wrote: > > Some wait_until_sent versions require the big > > tty mutex, others don't and some callers of > > wait_until_sent already hold it while other don't. > > That leads to recursive use of the BTM in these > > functions, which we're trying to get rid of. > > I don't believe any of the currently live ones do. > > > drivers/char/amiserial.c | 6 +++--- > > drivers/char/generic_serial.c | 2 +- > > Both ex drivers > > > drivers/char/hvc_console.c | 2 +- > > drivers/char/hvcs.c | 2 +- > > Doesn't seemn to need it > > > drivers/char/ip2/ip2main.c | 20 +++++++++++++++++--- > > I don't think we care - the driver is a mess, its probably not been used > in years > > > drivers/char/serial167.c | 6 +++--- > > Historical value only and broken > > > drivers/char/specialix.c | 2 +- > > Broken > > > drivers/serial/68328serial.c | 2 +- > > drivers/serial/68360serial.c | 5 ++--- > > Both defunct > > > drivers/serial/crisv10.c | 12 +++++++----- > > Defunct > > > net/irda/ircomm/ircomm_tty.c | 2 +- > > Semi-defunct at best > > This makes me think that now might be a good time to consign the broken > crap to the bitbucket unless someone stands up with hardware and who > wants to maintain it.
I will be glad to do this, moving these drivers to the staging tree so that they can be removed in 6-8 months, much like some wireless drivers are about to have happen to them.
So, which ones should I move? How about to start with the ones you listed above: drivers/char/amiserial.c drivers/char/generic_serial.c drivers/char/ip2/ip2main.c drivers/char/serial167.c drivers/char/specialix.c drivers/serial/68328serial.c drivers/serial/68360serial.c drivers/serial/crisv10.c
Any others you want to see move out of the tree?
thanks,
greg k-h
| |