Messages in this thread | | | Date | Wed, 5 May 2010 09:40:47 -0300 | Subject | Re: [PATCH] serial: mpc52xx_uart: fix null pointer dereference | From | Leonardo Chiquitto <> |
| |
On Tue, May 4, 2010 at 7:18 PM, Anatolij Gustschin <agust@denx.de> wrote: > Commit 6acc6833510db8f72b5ef343296d97480555fda9 > introduced NULL pointer dereference and kernel crash > on ppc32 machines while booting. Fix this bug now. > > Reported-by: Leonardo Chiquitto <leonardo.lists@gmail.com> > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > drivers/serial/mpc52xx_uart.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c > index a176ab4..02469c3 100644 > --- a/drivers/serial/mpc52xx_uart.c > +++ b/drivers/serial/mpc52xx_uart.c > @@ -1467,7 +1467,7 @@ mpc52xx_uart_init(void) > /* > * Map the PSC FIFO Controller and init if on MPC512x. > */ > - if (psc_ops->fifoc_init) { > + if (psc_ops && psc_ops->fifoc_init) { > ret = psc_ops->fifoc_init(); > if (ret) > return ret; > -- > 1.7.0.4
Thanks for the quick fix, Anatolij. I just tested it and confirm it resolves the problem.
Leonardo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |