lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: Fix performance issue with perf report
On Tue, 04 May 2010, Anton Blanchard wrote:

>
> On a large machine we spend a lot of time in perf_header__find_attr when
> running perf report.
>
> If we are parsing a file without PERF_SAMPLE_ID then for each sample we call
> perf_header__find_attr and loop through all counter IDs, never finding a match.
> As the machine gets larger there are more per cpu counters and we spend an
> awful lot of time in there.
>
> The patch below initialises each sample id to -1ULL and checks for this in
> perf_header__find_attr. We may need to do something more intelligent eventually
> (eg a hash lookup from counter id to attr) but this at least fixes the most
> common usage of perf report.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>

Acked-by: Eric B Munson <ebmunson@us.ibm.com>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-05-04 13:59    [W:0.128 / U:9.656 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site