lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwmon: applesmc: Add temperature sensor labels to sysfs interface
Jean Delvare wrote:
[...]
>> @@ -1578,6 +1717,8 @@ static int __init applesmc_init(void)
>> }
>> ret = sysfs_create_file(&pdev->dev.kobj,
>> temperature_attributes[i]);
>
> Missing error handling.
>
>> + ret = sysfs_create_file(&pdev->dev.kobj,
>> + label_attributes[i]);
>> if (ret)
>> goto out_temperature;
>> }
>

Shoot, my bad review. Will send a new patch. While at it, the same function
seems to leak fan attribute groups. Want me to correct such issues (in another
patch)?

Henrik



\
 
 \ /
  Last update: 2010-05-04 13:19    [W:0.033 / U:12.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site