lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH tip/core/rcu 28/48] net: Make accesses to ->br_port safe for sparse RCU
On Tue,  4 May 2010 13:19:38 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:

> The new versions of the rcu_dereference() APIs requires that any pointers
> passed to one of these APIs be fully defined. The ->br_port field
> in struct net_device points to a struct net_bridge_port, which is an
> incomplete type. This commit therefore changes ->br_port to be a void*,
> and introduces a br_port() helper function to convert the type to struct
> net_bridge_port, and applies this new helper function where required.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: David Miller <davem@davemloft.net>
> Cc: Stephen Hemminger <shemminger@linux-foundation.org>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>

I would rather make the bridge hook generic and not take a type argument.


\
 
 \ /
  Last update: 2010-05-04 23:31    [W:0.225 / U:3.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site