Messages in this thread | | | From | Marcelo Jimenez <> | Date | Tue, 4 May 2010 14:35:50 -0300 | Subject | Re: Suspicious compilation warning |
| |
Hi,
On Tue, Apr 20, 2010 at 20:07, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > > Well, it'll be about this number on everything using sparsemem extreme: > > #define SECTIONS_PER_ROOT (PAGE_SIZE / sizeof (struct mem_section)) > > and with only 32 sections, this is going to give a NR_SECTION_ROOTS value > of zero. I think the calculation of NR_SECTIONS_ROOTS is wrong. > > #define NR_SECTION_ROOTS (NR_MEM_SECTIONS / SECTIONS_PER_ROOT) > > Clearly if we have 1 mem section, we want to have one section root, so > I think this division should round up any fractional part, thusly: > > #define NR_SECTION_ROOTS ((NR_MEM_SECTIONS + SECTIONS_PER_ROOT - 1) / SECTIONS_PER_ROOT)
Seems correct to me, Is there any idea when this gets committed?
Regards, Marcelo. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |