Messages in this thread | | | Date | Tue, 04 May 2010 19:22:51 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH 04/12] perf: add @rq to perf_event_task_sched_out() |
| |
Hello,
On 05/04/2010 07:11 PM, Peter Zijlstra wrote: > On Tue, 2010-05-04 at 14:38 +0200, Tejun Heo wrote: >> Add @rq to perf_event_task_sched_out() so that its argument matches >> those of trace_sched_switch(). This will help unifying notifiers in >> sched. > > The alternative is dropping rq from the trace events, its not like > anybody outside sched.o can do anything sensible with it anyway.
The comment in include/trace/events/sched.h says...
* (NOTE: the 'rq' argument is not used by generic trace events, * but used by the latency tracer plugin. )
So, I left it there. It would be great if all those @rq params can be removed tho. The latency tracer thing needs it, right?
Thanks.
-- tejun
| |