lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Staging: RAR support - bring ready to move from staging
On Tue, May 04, 2010 at 05:27:04PM +0100, Alan Cox wrote:
> On Tue, 4 May 2010 08:51:12 -0700
> Greg KH <greg@kroah.com> wrote:
>
> > On Tue, May 04, 2010 at 10:50:32AM +0100, Alan Cox wrote:
> > >
> > > rar: perform a clean up pass
> > >
> > > - Move to a registration model where each RAR is claimed/unclaimed
> > > - Use that to fix the client stuff (one client per RAR so no need
> > > to queue stuff)
> > > - Support unregister so drivers can rmmod themselves safely
> > > - Fix locking hang on calling rar lock from rar callback
> > > - Clean up
> > > - Kerneldoc
> >
> > I get the following build errors with this patch:
> > CC [M] drivers/staging/memrar/memrar_handler.o
> > drivers/staging/memrar/memrar_handler.c: In function
> > ‘memrar_init’: drivers/staging/memrar/memrar_handler.c:910: warning:
> > passing argument 1 of ‘register_rar’ makes integer from pointer
> > without a cast
>
> Expected - its a staging driver so I thought a patch that broke the API
> of another staging driver was fine (the second patch will fix it up)

Ah, those were two different drivers, that makes more sense.

It's not nice to break the build, I can't take a patch that is known to
do that, sorry. Care to merge them together?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-05-04 19:23    [W:0.033 / U:0.244 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site